Fix oauth2 mock #5522
Merged
Fix oauth2 mock #5522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondfeng
requested review from
deepakrkris,
emonddr and
jannyHou
as code owners
Contributor
Author
|
Fixes #5520 |
bajtos
reviewed
May 22, 2020
bajtos
reviewed
May 22, 2020
| "name": "@loopback/mock-oauth2-provider", | ||
| "version": "0.0.3", | ||
| "description": "mocks the oauth2 authorization flow", | ||
| "private": true, |
Member
There was a problem hiding this comment.
I thought we were intentionally keeping this package private ?
Contributor
Author
There was a problem hiding this comment.
Per #5520, when the example-passport-login is cloned with lb4 example, npm i fails as this package is devDep of example-passport-login.
Member
|
See also #5523 which is a smaller version of this PR. |
1 task
raymondfeng
force-pushed
the
fix-oauth2-mock
branch
from
6414b69 to
5f16eba
Compare
jannyHou
approved these changes
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈