Skip to content

Add "signup" / create user in authentication-jwt module #5602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HrithikMittal wants to merge 1 commit into from
Closed

Add "signup" / create user in authentication-jwt module #5602

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 36 additions & 1 deletion extensions/authentication-jwt/src/__tests__/fixtures/controllers/user.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
UserService,
} from '@loopback/authentication';
import {inject} from '@loopback/core';
import {get, post, requestBody} from '@loopback/rest';
import {get, post, requestBody, getModelSchemaRef} from '@loopback/rest';
import {SecurityBindings, securityId, UserProfile} from '@loopback/security';
import {TokenServiceBindings, User, UserServiceBindings} from '../../../';
import {Credentials} from '../../../services/user.service';
Expand Down Expand Up @@ -95,4 +95,39 @@ export class UserController {
async whoAmI(): Promise<string> {
return this.user[securityId];
}
@post('/signup', {
responses: {
'200': {
description: 'User',
content: {
'application/json': {
schema: {
'x-ts-type': User,
},
},
},
},
},
})
async signUp(
@requestBody({
content: {
'application/json': {
schema: getModelSchemaRef(NewUserRequest, {
Copy link
Contributor

@madaky madaky May 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No definition for NewUserRequest

Copy link
Contributor

@jannyHou jannyHou Jun 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HrithikMittal you can find NewUserRequest here
https://github.com/strongloop/loopback-next/blob/master/examples/todo-jwt/src/controllers/user.controller.ts#L22-L29

title: 'NewUser',
}),
},
},
})
newUserRequest: NewUserRequest,
): Promise<User> {
const password = await hash(newUserRequest.password, await genSalt());
Copy link
Contributor

@madaky madaky May 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No definition for hash and gen salt

Copy link
Contributor

@jannyHou jannyHou Jun 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are imported from bcryptjs:
https://github.com/strongloop/loopback-next/blob/master/examples/todo-jwt/src/controllers/user.controller.ts#L19

const savedUser = await this.userRepository.create(
Copy link
Contributor

@madaky madaky May 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will throw a property does not exist. as no dependency injection.

_.omit(newUserRequest, 'password'),
);

await this.userRepository.userCredentials(savedUser.id).create({password});

return savedUser;
}
}