Skip to content

Conversation

@agnes512
Copy link
Contributor

@agnes512 agnes512 commented Jun 1, 2020

Closes #4879

Screen Shot 2020-06-01 at 18 18 08

Screen Shot 2020-06-01 at 18 18 19

Screen Shot 2020-06-01 at 18 18 35

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@agnes512
Copy link
Contributor Author

agnes512 commented Jun 2, 2020

Handling ObjectId part is moved to mongo connector README, see loopbackio/loopback-connector-mongodb#576

Copy link
Contributor

@nabdelgadir nabdelgadir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just suggestions so feel free to ignore what doesn't fit 👍

Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there. A few minor comments. No need further approval from me. Thanks!

@agnes512 agnes512 merged commit c51311e into master Jun 3, 2020
@agnes512 agnes512 deleted the mongo-tut branch June 3, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs] MongoDB connector docs should cover LB4 content

4 participants