feat(pooling): add an extension to provide pooling service #5681
Conversation
raymondfeng
added
Extensions
IoC/Context
raymondfeng
force-pushed
the
binding-pool
branch
5 times, most recently
from
f600efe to
f2ef1ac
Compare
|
+1 to implement this as an experimental extension. I don't have bandwidth to review the proposal. Can you @raymondfeng please pick somebody from the team to become a co-owner of the new package and let that person review the initial version. |
raymondfeng
force-pushed
the
binding-pool
branch
2 times, most recently
from
f42a945 to
92f9fbd
Compare
raymondfeng
force-pushed
the
binding-pool
branch
from
92f9fbd to
6e027ed
Compare
raymondfeng
force-pushed
the
binding-pool
branch
2 times, most recently
from
9fb50ec to
c7e0470
Compare
| }); | ||
|
|
||
| it('acquires/releases a resource from the pool', async () => { | ||
| const poolService = await givenPoolService({max: 5}); |
There was a problem hiding this comment.
Why not leave it out {max: 5}? It makes it look like the test has something to do with the parameter, when it is not. Same applies to other locations.
|
|
||
| it('acquires/releases a resource from the pool', async () => { | ||
| const poolService = await givenPoolService({max: 5}); | ||
| poolService.start(); |
There was a problem hiding this comment.
poolService.start(); is not called in some places. How does it work? This behavior should be documented.
There was a problem hiding this comment.
My assumption is that poolService will not be usable for anything (eg: poolService.run) unless it is started.
There was a problem hiding this comment.
Quoted from generic-pool:
autostart: boolean, should the pool start creating resources, initialize the evictor, etc once the constructor is called. If false, the pool can be started by calling pool.start, otherwise the first call to acquire will start the pool. (default true)
extensions/pooling/src/__tests__/acceptance/pooling.acceptance.ts
Outdated
Show resolved
Hide resolved
| function invokePoolableMethod(resource: Poolable, method: keyof Poolable) { | ||
| if (typeof resource[method] === 'function') { | ||
| return resource[method]!(); | ||
| } |
There was a problem hiding this comment.
else: should we throw an error? Failing silently (eg: in case of a typo) doesn't sound good to me.
There was a problem hiding this comment.
Not really in this case as the hook method can be optional. I added more debug statements.
| this.pool = createPool(factory, { | ||
| max: 8, // Default to 8 instances | ||
| ...this.options.poolOptions, | ||
| autostart: false, |
There was a problem hiding this comment.
If autostart is to be configurable, it must be specified before ...this.options.poolOptions.
There was a problem hiding this comment.
I intentionally disable autostart to fit into our life cycles. Added more comments in the code.
extensions/pooling/src/__tests__/acceptance/pooling.acceptance.ts
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1 @@ | |||
| # Unit tests | |||
There was a problem hiding this comment.
How about some unit tests?
There was a problem hiding this comment.
The pooling service is a wrapper of generic-pool. I believe the extra functions have been covered by the acceptance tests.
|
Looks mostly good, left some comments. |
raymondfeng
force-pushed
the
binding-pool
branch
from
c7e0470 to
cbfed3e
Compare
|
@hacksparrow Thank you for the comments. PTAL. |
raymondfeng
force-pushed
the
binding-pool
branch
from
cbfed3e to
cea6b6e
Compare
https://github.com/strongloop/loopback-next/blob/binding-pool/extensions/pooling/README.md
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈