Skip to content

Conversation

@bajtos
Copy link
Member

@bajtos bajtos commented Jun 9, 2020

  • Remove unused dependency @loopback/metadata from extensions/authentication-passport and packages/authentication
  • Remove references to @loopback/metadata, rework code and docs to import from @loopback/core instead.

This is a follow-up for #5659, see also #5550.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

bajtos added 3 commits June 9, 2020 10:14
Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
Remove references to `@loopback/metadata`, rework code and docs
to import from `@loopback/core` instead.

Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
@bajtos bajtos added developer-experience Issues affecting ease of use and overall experience of LB users Docs labels Jun 9, 2020
@bajtos bajtos requested a review from raymondfeng June 9, 2020 08:24
@bajtos bajtos self-assigned this Jun 9, 2020
@bajtos bajtos merged commit d39d007 into master Jun 9, 2020
@bajtos bajtos deleted the docs/hide-metadata-pkg branch June 9, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

developer-experience Issues affecting ease of use and overall experience of LB users Docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants