Skip to content

docs: add Oracle connector tut for lb4 #5755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
agnes512 merged 1 commit into from
Jun 19, 2020
Merged

docs: add Oracle connector tut for lb4 #5755

agnes512 merged 1 commit into from
Jun 19, 2020

Conversation

@agnes512
Copy link
Contributor

@agnes512 agnes512 commented Jun 16, 2020 •
edited
Loading

closes #4880

Screen Shot 2020-06-19 at 16 08 57

Screen Shot 2020-06-19 at 16 09 04

Screen Shot 2020-06-19 at 16 09 12

Screen Shot 2020-06-19 at 16 09 19

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@agnes512 agnes512 changed the title docs: add oracle connector tut for lb4 docs: add Oracle connector tut for lb4 Jun 16, 2020
@agnes512 agnes512 added the Docs label Jun 16, 2020
@agnes512 agnes512 requested a review from hacksparrow June 16, 2020 19:14
dhmlau
dhmlau reviewed Jun 17, 2020
View reviewed changes
Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I had a minor comment.

@dhmlau dhmlau assigned dhmlau and agnes512 and unassigned dhmlau Jun 19, 2020
@agnes512 agnes512 marked this pull request as ready for review June 19, 2020 20:11
@agnes512 agnes512 merged commit 4932c6c into master Jun 19, 2020
@agnes512 agnes512 deleted the oracle-tut branch June 19, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhmlau dhmlau dhmlau approved these changes

@hacksparrow hacksparrow Awaiting requested review from hacksparrow

Assignees

@agnes512 agnes512

Labels

Docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Docs] Oracle connector docs should cover LB4 content

3 participants

@agnes512 @dhmlau