Skip to content

Conversation

@bajtos
Copy link
Member

@bajtos bajtos commented Jun 19, 2020

This is a follow-up to #5718, see also #5549.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once @raymondfeng's comment is addressed. Thanks.

Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
@bajtos bajtos force-pushed the docs/move-error-codes branch from a74c80b to 06d811b Compare June 22, 2020 15:12
@bajtos
Copy link
Member Author

bajtos commented Jun 22, 2020

Based on discussion with @raymondfeng, we will stick with Sentence-style.html to land my PRs and then normalize URL slugs afterwards, as this part may take a bit longer to reach consensus.

@bajtos bajtos merged commit 89b5af2 into master Jun 22, 2020
@bajtos bajtos deleted the docs/move-error-codes branch June 22, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants