Skip to content

Conversation

@bajtos
Copy link
Member

@bajtos bajtos commented Jul 14, 2020

Import OpenAPI-related helpers from @loopback/rest instead.

See #5692

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@raymondfeng
Copy link
Contributor

Please fix build errors:

extensions/typeorm/src/typeorm.utils.ts:10:8 - error TS2307: Cannot find module '@loopback/openapi-v3' or its corresponding type declarations.
10 } from '@loopback/openapi-v3';
          ~~~~~~~~~~~~~~~~~~~~~~

Copy link
Contributor

@raymondfeng raymondfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address #5932 (comment)

@bajtos
Copy link
Member Author

bajtos commented Jul 16, 2020

Please fix build errors:

extensions/typeorm/src/typeorm.utils.ts:10:8 - error TS2307: Cannot find module '@loopback/openapi-v3' or its corresponding type declarations.
10 } from '@loopback/openapi-v3';
          ~~~~~~~~~~~~~~~~~~~~~~

Weird. npm it is passing on my machine 🤔 I'll investigate.

@bajtos bajtos force-pushed the feat/hide-openapi-v3 branch from 9576391 to 25bd30b Compare July 16, 2020 06:49
@bajtos
Copy link
Member Author

bajtos commented Jul 16, 2020

Managed to reproduce the problem after running npm run clean:lerna. The commit 25bd30b is fixing the issue by moving @loopback/rest from dev-dependencies to regular dependencies, using the same approach as in #5927. Once these two PRs are landed, I can open a follow-up PR to move @loopback/rest to peer-dependencies.

@raymondfeng LGTY now?

@bajtos bajtos requested a review from raymondfeng July 16, 2020 06:52
Import OpenAPI-related helpers from `@loopback/rest` instead.

Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
@bajtos bajtos force-pushed the feat/hide-openapi-v3 branch from 25bd30b to 4da80ff Compare July 16, 2020 11:06
@bajtos bajtos merged commit 0e6b51e into master Jul 16, 2020
@bajtos bajtos deleted the feat/hide-openapi-v3 branch July 16, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants