Skip to content

fix(docs): fix extension desc #5982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dhmlau merged 1 commit into from
Jul 21, 2020
Merged

fix(docs): fix extension desc #5982

dhmlau merged 1 commit into from
Jul 21, 2020

Conversation

@dhmlau
Copy link
Member

@dhmlau dhmlau commented Jul 21, 2020

Fixes the soft-delete extension description according to #5707 (comment).

cc @samarpanB

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@dhmlau dhmlau self-assigned this Jul 21, 2020
@dhmlau dhmlau added the Docs label Jul 21, 2020
samarpan-b
samarpan-b reviewed Jul 21, 2020
View reviewed changes
Copy link

@samarpan-b samarpan-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@dhmlau dhmlau merged commit 0382ae8 into master Jul 21, 2020
@dhmlau dhmlau deleted the ext branch July 21, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nabdelgadir nabdelgadir nabdelgadir approved these changes

+1 more reviewer

@samarpan-b samarpan-b samarpan-b left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dhmlau dhmlau

Labels

Docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhmlau @samarpan-b @nabdelgadir