Skip to content

Conversation

@bajtos
Copy link
Member

@bajtos bajtos commented Aug 3, 2020

The first commit adds connector README layout files from loopback.io, the second commit updates docs preview build script to include connector READMEs in the preview site too. These changes together makes it easier to preview connector-related changes via npm run docs:start.

The last commit adds a new page Executing database commands, see #3342.

I am intentionally not including connector-specific examples, my plan is to add them to individual connector README files.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@bajtos bajtos requested review from agnes512 and emonddr August 3, 2020 15:18
@bajtos bajtos self-assigned this Aug 3, 2020
@bajtos bajtos added Docs Repository Issues related to @loopback/repository package labels Aug 3, 2020
bajtos added 3 commits August 4, 2020 18:26
Keep the layout files for connectors rendered in LB4 doc site
inside loopback-next, together with other LB4 content.

The content of the imported files was reformatted using Prettier.

Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
@bajtos bajtos force-pushed the docs/repository-execute branch from 3ee1b1d to b923d67 Compare August 4, 2020 16:28
Copy link
Contributor

@agnes512 agnes512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am intentionally not including connector-specific examples, my plan is to add them to individual connector README files.

👍 This is a good content to be mentioned in "Configuring DataSource" page #6061

@bajtos bajtos merged commit fb38303 into master Aug 11, 2020
@bajtos bajtos deleted the docs/repository-execute branch August 11, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docs Repository Issues related to @loopback/repository package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants