Skip to content

Conversation

@dhmlau
Copy link
Member

@dhmlau dhmlau commented Jan 26, 2021

Signed-off-by: Diana Lau dhmlau@ca.ibm.com

This PR adds:

  • the graphql example to the Examples.md
  • example-graphql in the lb4 example list

It uses #5556 as the reference.

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@raymondfeng
Copy link
Contributor

Code lint fails on CI

Copy link
Member

@achrinza achrinza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: The commit type should be feat: as it's adding a new example.

Other than that, LGTM. 👍

Signed-off-by: Diana Lau <dhmlau@ca.ibm.com>
@dhmlau dhmlau merged commit 6e53690 into master Jan 27, 2021
@dhmlau dhmlau deleted the graphql-ex branch January 27, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants