Skip to content

Conversation

@shimks
Copy link
Contributor

@shimks shimks commented Jan 25, 2018

The tests that run when npm run release is run fail because api-docs is built when being bootstrapped in example-getting-started and aren't deleted afterwards. Because of this, the presence of api-docs are checked for when cloning from github and fails because api-docs aren't there. Besides, creating api-docs in example-getting-started seem moot.

This PR would remove api-docs building scripts from example-getting-started.

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Related API Documentation was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in packages/example-* were updated

@raymondfeng
Copy link
Contributor

@shimks I fixed the issue with https://github.com/strongloop/loopback-next/pull/913/files#diff-d01db79a7f64cff0d9cfd0a4d99e55d7R33 too. It makes sure api-docs is ignored for the test.

@shimks
Copy link
Contributor Author

shimks commented Jan 25, 2018

Closing as #913 fixes this issue

@shimks shimks closed this Jan 25, 2018
@shimks shimks deleted the rm-example-api-docs branch January 25, 2018 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants