Bring in loopback4-example-rpc-server #915
Conversation
| npm i -g @loopback/cli | ||
| ``` | ||
|
|
||
| 2. Download the "getting-started" application. |
There was a problem hiding this comment.
getting-started -> rpc-server
| "loopback-application", | ||
| "loopback" | ||
| ], | ||
| "main": "./dist/src/index.js", |
There was a problem hiding this comment.
Shouldn't this point to index.js?
There was a problem hiding this comment.
Actually it appears that index.d.ts and index.js are missing in this example yet it supports Node 6 so I'm actually confused as to how this even passes on 6 rn.
There was a problem hiding this comment.
It should; the original project was made before the CLI tooling existed.
| @@ -0,0 +1 @@ | |||
| --recursive | |||
There was a problem hiding this comment.
This file can be removed as it's not used by the test script in package.json
| @@ -0,0 +1,17 @@ | |||
| { | |||
There was a problem hiding this comment.
We don't need to a tslint file when using lb-tslint. This file can be removed.
| @@ -0,0 +1,4 @@ | |||
| { | |||
There was a problem hiding this comment.
This file can be removed. None of the other example-* repos have it.
|
|
||
| 3. Switch to the directory and install dependencies. | ||
| ``` | ||
| cd loopback4-example-getting-started && npm i |
There was a problem hiding this comment.
Don't forget about these, either! :)
| "loopback-application", | ||
| "loopback" | ||
| ], | ||
| "main": "./dist/src/index.js", |
There was a problem hiding this comment.
It should; the original project was made before the CLI tooling existed.
bajtos
force-pushed
the
example/rpc-server
branch
from
f8d08a5 to
84dcb6d
Compare
|
Thank you @kjdelisle and @virkt25 for your detailed review. So many trivial mistakes, I feel bad about not being more diligent when checking my changes myself. I believe I have addressed all your comments now (see 84dcb6d). |
|
FWIW, the build is failing because of a know problem in one of our dependencies, see sinonjs/nise#27 and sinonjs/nise#29 |
The first commit 929737c brings in an exact copy of https://github.com/strongloop/loopback4-example-rpc-server.
The second commit f8d08a5 contains changes necessary to integrate the example with the rest of the monorepo.
See #836
Checklist
npm testpasses on your machinepackages/cliwere updatedpackages/example-*were updated