-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(rest): allow basePath in RestServer configuration #920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Keep in mind that this requires more unit tests, which I'll add later. |
718e615 to
93dd326
Compare
| export interface RestServerConfig { | ||
| host?: string; | ||
| port?: number; | ||
| basePath?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any code to use server-level basePath? Is it to be implemented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
hi @kjdelisle there is some change for the Could you hold on adding more code and we do a pair programming next week? Thanks :) |
|
IMO, this is not needed for our MVP, therefore this pull request should be closed until MVP is done. If we consider non-configurable |
|
This PR can probably be closed, since the final form of what we're working with will change based on @jannyHou 's upcoming update to move us to OpenAPI v3. |
|
@kjdelisle I had a talk with @bajtos this morning, most of the And please note in the coming openapi3 spec, there is no root level property called |
Part of #914
Add the capability to set basePath as a part of your config.
Checklist
npm testpasses on your machinepackages/cliwere updatedpackages/example-*were updated