-
Notifications
You must be signed in to change notification settings - Fork 383
lb4: describe "lb4 example" command #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
shimks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bschrammIBM
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny edit needed due to spelling typo:
+- Name of the example to download. If the name had been supplied from the
+command-line, the prmpt is skipped.
Should be: prompt (obviously)
pages/en/lb4/Download-examples.md
Outdated
| The tool will prompt you for: | ||
|
|
||
| - Name of the example to download. If the name had been supplied from the | ||
| command-line, the prmpt is skipped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: prmpt -> prompt
pages/en/lb4/Download-examples.md
Outdated
|
|
||
| ### Output | ||
|
|
||
| The example project is download to a new directory. For example, when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be is downloaded instead of is download.
pages/en/lb4/Download-examples.md
Outdated
| ### Output | ||
|
|
||
| The example project is download to a new directory. For example, when | ||
| downloading `getting-started` example, the tool stores the files in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a suggestion. I'm wondering if it would be better to rephrase the last sentence to something like:
... the tool stores the files under the newly created loopback4-example-getting-started directory.
pages/en/lb4/Download-examples.md
Outdated
|
|
||
| ### Synopsis | ||
|
|
||
| Downloads a LoopBack example project from our GitHub monorepo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be good to include the loopback-next repo link to our GitHub monorepo?
|
@bschrammIBM @dhmlau thank you for the review. I have addressed your comments, PTAL again. |
I have fixed the typo you had pointed out.
See loopbackio/loopback-next#836 and loopbackio/loopback-next#848