Skip to content

Conversation

@bajtos
Copy link
Member

@bajtos bajtos commented Feb 8, 2018

@bajtos bajtos requested review from dhmlau, kjdelisle and shimks February 8, 2018 14:15
@bajtos bajtos requested a review from bschrammIBM as a code owner February 8, 2018 14:15
@bajtos bajtos self-assigned this Feb 8, 2018
@bajtos bajtos added this to the February 2018 milestone Feb 8, 2018
Copy link
Contributor

@shimks shimks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bschrammIBM bschrammIBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny edit needed due to spelling typo:
+- Name of the example to download. If the name had been supplied from the
+command-line, the prmpt is skipped.

Should be: prompt (obviously)

The tool will prompt you for:

- Name of the example to download. If the name had been supplied from the
command-line, the prmpt is skipped.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: prmpt -> prompt


### Output

The example project is download to a new directory. For example, when
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be is downloaded instead of is download.

### Output

The example project is download to a new directory. For example, when
downloading `getting-started` example, the tool stores the files in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion. I'm wondering if it would be better to rephrase the last sentence to something like:

... the tool stores the files under the newly created loopback4-example-getting-started directory.


### Synopsis

Downloads a LoopBack example project from our GitHub monorepo.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be good to include the loopback-next repo link to our GitHub monorepo?

@bajtos
Copy link
Member Author

bajtos commented Feb 9, 2018

@bschrammIBM @dhmlau thank you for the review. I have addressed your comments, PTAL again.

@bajtos bajtos dismissed bschrammIBM’s stale review February 12, 2018 08:06

I have fixed the typo you had pointed out.

@bajtos bajtos merged commit 2e8c062 into gh-pages Feb 12, 2018
@bajtos bajtos deleted the lb4/describe-lb4-example-command branch February 12, 2018 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants