Skip to content

feat: support sidebar groups with no page link #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bajtos merged 1 commit into from
Jun 18, 2020
Merged

feat: support sidebar groups with no page link #996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion _includes/sidebar_menu_list_items.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@
{% if item.output contains "web" %}
<li class="{% if item.children.size > 0 %} tree-parent {%else%} leaf-node {% endif %} {% if pageurl.last == item.url %}active{% endif %}">
{% if item.children.size > 0 %} <a class="show-hide" href="#"></span> {% endif %}
<a class="page-link" href="{{item.url}}">{{ item.title }}</a>
{% if item.url %}
<a class="page-link" href="{{item.url}}">{{ item.title }}</a>
{% else %}
<a class="section-name" href="#">{{ item.title }}</a>
{% endif %}
{% if item.children.size > 0 %}
<ul class="nav-list">
{% include sidebar_menu_list_items.liquid menuitems=item.children %}
Expand Down
6 changes: 5 additions & 1 deletion css/customstyles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,17 +737,19 @@ ul#mysidebar, #mysidebar ul{
display: block;
}

#mysidebar .section-name,
#mysidebar .page-link {
padding: 3px 5px;
margin-left: 1em;
}

#mysidebar > li > .section-name,
#mysidebar > li > .page-link {
text-transform: uppercase;
font-size: 11px;
font-weight: 500;
}

#mysidebar .leaf-node>.page-link::before{
content: "▪";
float:left;
Expand All @@ -773,6 +775,8 @@ ul#mysidebar, #mysidebar ul{
text-decoration: none;
}

#mysidebar li.active>a.section-name,
#mysidebar a.section-name:hover,
#mysidebar li.active>a.page-link,
#mysidebar a.page-link:hover{
background: #e3eeff;
Expand Down
7 changes: 5 additions & 2 deletions js/customscripts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,16 @@ function setupSidebarTreeNav(){
//add expanded class to active tree parents
$('.tree-parent.active').addClass('expanded');

$('a.show-hide').click(function (e) {
$('a.show-hide').click(toggleSectionChildren);
$('a.section-name').click(toggleSectionChildren);

function toggleSectionChildren(e) {
console.log('clicked', this);
$(this)
.blur()
.parent().toggleClass('expanded')
.children('ul.nav-list').toggle(200);
return false;
// $(this).parent().children('ul.nav-list').toggle(200);
});
}
}