chore: refactor the repo into a monorepo managed by lerna #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-admike
reviewed
Apr 19, 2019
Contributor
b-admike
left a comment
b-admike
left a comment
There was a problem hiding this comment.
Great effort @raymondfeng 💯. Overall, I like this approach, but it would be great for reviewers if you were to split this commit into smaller logical/progressive ones or perhaps in a comment share what you've had to do to get to this point so people are aware of what kind of changes went in (good for learning too :-)).
packages/recommender/src/__tests__/integration/recommender.integration.ts
Show resolved
Hide resolved
raymondfeng
force-pushed
the
monorepo
branch
2 times, most recently
from
379190d to
2e41ef4
Compare
Signed-off-by: Raymond Feng <enjoyjava@gmail.com>
Signed-off-by: Raymond Feng <enjoyjava@gmail.com>
b-admike
approved these changes
Apr 20, 2019
| } from '../../src/keys'; | ||
| const recommendations = require('../../recommender/recommendations.json'); | ||
| createRecommendationServer, | ||
| HttpServer, |
Contributor
There was a problem hiding this comment.
Is this a re-export from @loopback/http-server?
packages/recommender/src/__tests__/integration/recommender.integration.ts
Show resolved
Hide resolved
| // License text available at https://opensource.org/licenses/MIT | ||
|
|
||
| export * from './mock-recommendation-app'; | ||
| export * from '@loopback/http-server'; |
nabdelgadir
approved these changes
Apr 22, 2019
Signed-off-by: Raymond Feng <enjoyjava@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Raymond Feng enjoyjava@gmail.com