Skip to content

Conversation

@shimks
Copy link
Contributor

@shimks shimks commented Jun 7, 2018

Description

Part of work to release a new semver version.
Follow the story on #73 for reasoning behind releasing as a new major version.

NOTE: Please look at just the first review to see the actual changes in the test file

Related issues

  • connect to <link_to_referenced_issue>

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

@shimks shimks requested review from bajtos and zbarbuto as code owners June 7, 2018 16:36
@shimks
Copy link
Contributor Author

shimks commented Jun 7, 2018

@slnode test please

1 similar comment
@bajtos
Copy link
Member

bajtos commented Jun 8, 2018

@slnode test please

Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@b-admike b-admike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@shimks shimks merged commit a431cf5 into master Jun 8, 2018
@shimks shimks deleted the drop-node-4 branch June 8, 2018 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants