#15 with #20 #21
Closed
#15 with #20 #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BowlingX
commented
Mar 22, 2025
| "test:eslint": "eslint --color src", | ||
| "test:jest": "jest --colors", | ||
| "test:prettier": "prettier -l \"src/**/*\"", | ||
| "test:attw": "attw . --pack --profile node16", |
Collaborator
Author
There was a problem hiding this comment.
I believe we do not need to support node10 anymore. Otherwise we would need to create a dedicated type file and add it to the root, for the compat export.
Owner
|
Thanks for your work on this! I'm not sure I understand the approach you're taking here... we'd close #15 and merge this instead? There are some issues linked to #15 (including issues that will auto-close when it's merged) and I find it harder to actually see the relevant changes here in order to review them -- personally I'd prefer to just merge #15 and rebase your existing PR on top of that if that's ok. I'm happy to do that now! |
Collaborator
Author
|
Sure, we can do that also :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will rebase #15 with #20