Merge?

[thxraph]

Hello!

Is a merge of the requests is gonna happen? What is the correct way to get this working again? should I use a fork from another user?

thank you,
Raphael

[mcbrain78]

Hi Raphael,

I am using PR94 in the meantime. It works well!

-Markus

[helicalchris]

it would be useful if PR94 was merged as until the new release hits pypi it doesn't get pulled into the Home Assistant integration

[lostfields]

I'll look into it, one concern about #94 is that it isn't only introducing new auth, but it's a complete rewrite.

[thxraph]

I'll look into it, one concern about #94 is that it isn't only introducing new auth, but it's a complete rewrite.

if it works.... because right now it doesn't.

Thank you guys for the info, I merged the changes manually and everything is working again after 2 little changes to my code for the auth. I have 2 scripts using the API to control the AC units via mqtt for nodered integration. 1 to make changes, 1 to pull the changes (read/write).

Thank you :)

[LudovicRousseau]

I agree with @lostfields here. The PR is not just adding support of the new auth but also unrelated code and API changes.

It was easy to adapt my code to the new API. see LudovicRousseau@b2989c6

But I think we can have the new auth support without breaking the API.

[thxraph]

Well, it makes sense, you don't want to break back compatibility.
I'll leave you pros to it. I don't know what is the extend of the modification, maybe a simple wrapper would do to keep backcompat but on the other hand that is how, slowly and over time, codebases become clusterf*#ks.
Given the amount of code built over this codebase, it would be great to get a new version that works... and could be simply pip updated.
I'm just a little hobby code thinkerer with an mqtt caller interfaced on it, and everything works again for me.
I'm also very grateful to @lostfields for this code given the terrible support from Panasonic... my next ACs will be Mitsubishi or Samsung as the support is much better there. I might end up converting the panas to ESP local mqtt and bypass the cloud completely.
Anyway, I diverge, many thanks to everybody involved, you guys are stars!
Raphael

[helicalchris]

Hi all so this being as it is, and I appreciate that the PR has its issues, is there a way forward for this project long term? I ask because the Home Assistant integration (and I assume lots of others) are using this, so we are all a bit stuck right now. I also appreciate chasing without helping isn’t particular helpful but believe me keeping me away from the code is best for everyone!

[lostfields]

If the author of PR #94 allows it, I can refactor it to make it less a rewrite but still keep the good stuff (more or less keep it backwards compatible). Don't know why that isn't done in the beginning @helicalchris

[danielcherubini]

@lostfields you can do that if you want :D

[lostfields]

I'm making a few changes in #100

[lostfields]

@thxraph @mcbrain78 @LudovicRousseau
Do you mind testing #100 and see if that works similar to #94 ? There is a few changes how the code is lay out.

[mcbrain78]

I‘m traveling unfortunately, and don’t have access to the AC for a while

[thxraph]

Hi, traveling too, i should be able to try end of next week.

…

On Wed, Aug 21, 2024, 09:53 mcbrain78 ***@***.***> wrote: I‘m traveling unfortunately, and don’t have access to the AC for a while — Reply to this email directly, view it on GitHub <#98 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEMBNJ3S6AP3HPKOBP3ZFITZSRBOPAVCNFSM6AAAAABLUXNWNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBRGM4DIMZWGM> . You are receiving this because you were mentioned.Message ID: ***@***.*** com>