fix: sanitize orphan tool results in continue history#183
Open
ki113r4bbi7 wants to merge 1 commit intolsdefine:mainfrom
Open
fix: sanitize orphan tool results in continue history#183ki113r4bbi7 wants to merge 1 commit intolsdefine:mainfrom
ki113r4bbi7 wants to merge 1 commit intolsdefine:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
/continuehistory before restoring it.tool_resultcontent as plain text instead of replaying it as a protocol tool result.tool_use/tool_resultpairs unchanged.Why
If an agent crashes while a tool call is in flight, a recovered session can contain a
tool_resultwithout the matching prior assistanttool_use. Replaying that history can make providers reject the next request with errors such asNo tool call found for function_call_output.Testing
python -m py_compile frontends/continue_cmd.py_parse_native_history:tool_resultis converted to texttool_resultremains intact