fix: use HTTPS for skill_search API endpoint#224
Open
Kailigithub wants to merge 1 commit intolsdefine:mainfrom
Open
fix: use HTTPS for skill_search API endpoint#224Kailigithub wants to merge 1 commit intolsdefine:mainfrom
Kailigithub wants to merge 1 commit intolsdefine:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changed the default
skill_searchAPI URL from plaintext HTTP to HTTPS, ensuring environment data (OS, shell, runtimes, tools, model info) is transmitted encrypted.Closes #204
Changes
memory/skill_search/skill_search/engine.py: ChangedDEFAULT_API_URLfromhttp://tohttps://memory/skill_search/SKILL.md: Updated documentation to reflect the HTTPS URLDetails
The
skill_searchmodule sends detected environment information (OS type, installed runtimes, available tools) to the API endpoint on every query. Using plaintext HTTP exposes this data to network interception. This fix ensures all API communication uses HTTPS by default.Users who need to override the URL can still set the
SKILL_SEARCH_APIenvironment variable.