Skip to content

fix for issue 100, crash on reuse#104

Open
msimerson wants to merge 3 commits into
lsongdev:masterfrom
NicTool:100-crash-reuse
Open

fix for issue 100, crash on reuse#104
msimerson wants to merge 3 commits into
lsongdev:masterfrom
NicTool:100-crash-reuse

Conversation

@msimerson
Copy link
Copy Markdown
Contributor

@msimerson msimerson commented May 25, 2026

Fixes #100
Fixes #91

📑 Description

Refactored client/udp.js with:

  • fix: drop mismatched IDs
  • fix: filter senders by resolver port
  • fix: write Packet.parse in a try/catch
  • fix: handle socket errors
  • feat: proper cleanup / teardown
  • feat: add a default 10s timeout (configurable)
  • feat: expand transaction IDs to 16-bit using crypto.randomInt(0x10000)

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed
  • I have added tests that exercise the bug in the issue and verify the changes add it

@msimerson
Copy link
Copy Markdown
Contributor Author

msimerson commented May 25, 2026

Note: unfortunately, this PR also has the commit from #103. Without it the tests would be unable to pass. Once #103 lands, I can rebase this and shrink the PR, or it can be cherry picked.

@msimerson msimerson changed the title 100 crash reuse fix for issue 100, crash on reuse May 25, 2026
@lsongdev
Copy link
Copy Markdown
Owner

I have sent invite link to you as a contributor, congrats and feel free to build this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants