Optimize mapMonotonic by using an Fmap class instead of Functor#140
Merged
konsumlamm merged 1 commit intolspitzner:masterfrom Feb 28, 2025
konsumlamm:fmap
Merged
Optimize mapMonotonic by using an Fmap class instead of Functor#140konsumlamm merged 1 commit intolspitzner:masterfrom konsumlamm:fmap
mapMonotonic by using an Fmap class instead of Functor#140konsumlamm merged 1 commit intolspitzner:masterfrom
konsumlamm:fmap
Conversation
Collaborator
|
Good catch! |
treeowl
approved these changes
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #55.
This is the same optimization as in #59. Due to the recursive nature of our instances, the
Functorinstance built a lot of unnecessary<$s, which are avoided by the newFmapclass. This is the only such remaining instance that I found.This change improves the performance of
mapMonotonicsignificantly (see benchmarks below).Benchmark results
Benchmarking
mapMonotonic (+ 1)on aMinQueue Intwith n random elements.Before:
After: