Conversation
df564e6 to
d4b9aeb
Compare
b4ed3d1 to
f91f1a0
Compare
|
@konsumlamm This PR moves a lot of things around, so I'm pretty much blocked on everything else till it goes in. |
konsumlamm
left a comment
There was a problem hiding this comment.
Are the Functor, Fodlable and Traversable instances of Down used anywhere? Also, I think a better module name instead of Data.PQueue.Prio.Max.Down would be Data.PQueue.Down, since it's not specific to MaxQueue or MaxPQueue.
I don't know.
Good point. |
* Remove all orphan instances. * One of the `unions` definitions used `foldl`; make it use `foldl'` instead. * Remove false caveat about amortized bounds. They definitely *do* hold in a persistent setting, and we're very careful to maintain that! Someone must have confused lazy-spined binomial queues with strict-spined ones.
|
|
Remove all orphan instances.
One of the
unionsdefinitions usedfoldl; make it usefoldl'instead.
Closes #52.