Skip to content

Followup to #59#67

Merged
konsumlamm merged 2 commits intolspitzner:masterfrom
konsumlamm:followup
Dec 17, 2021
Merged

Followup to #59#67
konsumlamm merged 2 commits intolspitzner:masterfrom
konsumlamm:followup

Conversation

@konsumlamm
Copy link
Copy Markdown
Collaborator

This PR addresses my comments in #59.

Changes:

  • add changelog entry
  • add missing @since annotations
  • add missing performance notes
  • remove unnecessary double spaces

Add changelog entry
Add missing `@since` annotations
Add missing performance notes
Remove unnecessary double spaces
Comment thread CHANGELOG.md Outdated
@treeowl
Copy link
Copy Markdown
Collaborator

treeowl commented Dec 17, 2021

Still approved

@konsumlamm konsumlamm merged commit 47d5fd4 into lspitzner:master Dec 17, 2021
@konsumlamm konsumlamm deleted the followup branch December 17, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants