DM-52541: reject diaSources in SPIKE mask regions #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
force-pushed
the
tickets/DM-52541
branch
from
a176645 to
e467c1c
Compare
isullivan
changed the title
erykoff
reviewed
Oct 22, 2025
Contributor
erykoff
left a comment
erykoff
left a comment
There was a problem hiding this comment.
I'm worried these defaults will crash if spike masking is off... what happens in those cases?
Contributor
Author
|
The |
isullivan
force-pushed
the
tickets/DM-52541
branch
from
e467c1c to
1e886c7
Compare
erykoff
approved these changes
Oct 22, 2025
isullivan
force-pushed
the
tickets/DM-52541
branch
from
1e886c7 to
2e401a1
Compare
isullivan
force-pushed
the
tickets/DM-52541
branch
from
2e401a1 to
846aede
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also reject sources with SAT or BAD set anywhere in their central 3x3 pixels, not just if all central pixels are flagged.