Skip to content

Conversation

@lu-value
Copy link
Owner

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a "get next line" function (ft_gnl) to the libft library for reading lines from file descriptors, and renames parameters in list manipulation functions for better clarity.

Changes:

  • Adds ft_gnl function implementation with supporting helper functions for reading lines from file descriptors
  • Renames parameter 'new' to 'new_node' in ft_lstadd_front and ft_lstadd_back functions for better clarity
  • Improves .gitignore file with better organization and additional patterns

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/ft_gnl.c New file implementing get-next-line functionality with buffer management and line extraction
src/ft_lstadd_front.c Renames parameter from 'new' to 'new_node' for clarity
src/ft_lstadd_back.c Renames parameter from 'new' to 'new_node' for clarity
includes/libft.h Adds BUFFER_SIZE definition, updates function declarations, and adds ft_gnl prototype
Makefile Adds ft_gnl.c to the source files list
.gitignore Fixes malformed pattern and adds comprehensive ignore patterns

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

lu-value and others added 2 commits January 28, 2026 23:43
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link

Copilot AI commented Jan 28, 2026

@lu-value I've opened a new pull request, #2, to work on those changes. Once the pull request is ready, I'll request review from you.

[WIP] WIP: Address feedback on Add ft_gnl function pull request
Copy link

Copilot AI commented Jan 28, 2026

@lu-value I've opened a new pull request, #3, to work on those changes. Once the pull request is ready, I'll request review from you.

@lu-value lu-value merged commit 8704e13 into main Jan 28, 2026
@lu-value lu-value deleted the feature/gnl branch January 28, 2026 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants