Fix crash when reading corrupted or incompatible Lucene index files#215
Merged
alanw merged 1 commit intoluceneplusplus:masterfrom May 22, 2025
Merged
Fix crash when reading corrupted or incompatible Lucene index files#215alanw merged 1 commit intoluceneplusplus:masterfrom
alanw merged 1 commit intoluceneplusplus:masterfrom
Conversation
This commit addresses critical crashes that occur when trying to read certain Lucene index files where field data may be corrupted or have incompatible format. Root causes: 1. Assertion failures in FieldsReader::doc() when bits flag or compressed field format is incompatible with expected values 2. Null pointer dereference in boost::shared_ptr when trying to add fields to a document with potentially corrupted data The fixes include: - Replace assertions with safe handling for invalid bit flags and format incompatibilities - Add null checks before dereferencing shared pointers in critical paths - Create field objects separately before adding them to documents - Add proper error handling for decompression failures - Ensure uncompress and string conversion methods never return null values These minimal changes maintain the original logic but make the code more robust when dealing with unexpected or corrupt index data. Instead of crashing, the code now gracefully handles these edge cases and continues processing where possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses critical crashes that occur when trying to read certain Lucene index files where field data may be corrupted or have incompatible format.
Root causes:
The fixes include:
These minimal changes maintain the original logic but make the code more robust when dealing with unexpected or corrupt index data. Instead of crashing, the code now gracefully handles these edge cases and continues processing where possible.