Reduce false positives and number of requests sent#16
Merged
luh2 merged 4 commits intoluh2:masterfrom Dec 17, 2018
Merged
Conversation
Author
|
I just noticed for number 2) there is already a method hasAuthenticationCharacteristic, but it does not seem to work. |
Author
|
It seems there is an incorrect not that will cause the hasAuthenticationCharacteristic to always return true:
This coding style makes it hard to discover bugs / determine the actual behaviour since the any() is error-prone and there are too many statements in a single line |
added 2 commits
December 15, 2018 16:17
Owner
|
Awesome pull request as usual! Thanks. It's merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce false positives by using a different approach for detecting JavaScript extensions. The current way will, for example, detect "jspa" as a script file. Another approach would be a more sophisticated way, for example, by rating/weighing the different criteria (content-type, file extension, mime-type ...)
Reduce number of requests sent by the extension by examining whether there is any authentication information in the base request at all.