Refactor/mappers and dtos

[luislh-dev]

No description provided.

[Copilot]

Pull Request Overview

This PR consolidates boilerplate by switching many classes from individual Lombok @Getter/@Setter to @Data, removes outdated DTOs and lifecycle callbacks, and introduces a new PersonBasicDTO with corresponding mapper and service/controller updates.

• Replaced @Getter/@Setter with @Data in entity and DTO classes
• Removed manual @PrePersist/@PreUpdate methods in favor of Hibernate timestamp annotations
• Added PersonBasicDTO and updated service, controller, and mapper to return it instead of the projection
• Deleted unused create-request DTOs

Reviewed Changes

Copilot reviewed 29 out of 30 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
UserEntity.java	Replaced Lombok getters/setters with @Data
RecordDetailCreateRequestDTO.java	Switched to @Data, but left unused imports
PeopleDtoMapper.java	Added toPersonBasicDto mapping method
PeopleServiceImpl.java	Updated findBasicById to map projection to PersonBasicDTO
PeopleController.java	Changed endpoint to return PersonBasicDTO
Other entity/DTO files	Similar Lombok annotation replacements and timestamp updates

Comments suppressed due to low confidence (2)

src/main/java/com/historialplus/historialplus/internal/people/service/PeopleServiceImpl.java:128

• Consider adding a unit test for findBasicById to verify the projection-to-DTO mapping, especially date and enum transformations in toPersonBasicDto.

        return repository.findBasicById(id).map(PeopleDtoMapper::toPersonBasicDto);

src/main/java/com/historialplus/historialplus/internal/user/entites/UserEntity.java:31

• [nitpick] Consider avoiding @Data on JPA entities; it generates equals/hashCode including all fields, which can cause issues with lazy associations—prefer @Getter/@Setter plus a tailored @EqualsAndHashCode(onlyExplicitlyIncluded = true).

@Data

[Copilot]

Remove the unused lombok.Getter and lombok.Setter imports now that @Data is used to avoid stale imports.

Suggested change

	import lombok.Getter;
	import lombok.Setter;

[luislh-dev]

Tener en cuenta que el FileDTO usar el getter y setter

[Copilot]

The DTO birthdate is a String but input.getBirthdate() likely returns a Date or LocalDate—add explicit formatting or conversion to avoid a type mismatch at runtime.

[luislh-dev]

🛠️

[luislh-dev]

Tener en cuenta que el FileDTO usar el getter y setter

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud