Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors enum/constant package names, introduces a TimeUtils helper for timezone-aware timestamps, and updates the file upload API to use a DTO-based create/save flow.
- Moved enums from
common.constantstocommon.enumsand updated all imports. - Added
TimeUtilsto standardize timezone-basedLocalDateTimeandInstantretrieval and replaced directZonedDateTimeusage. - Refactored file upload endpoints and service to accept
FilesCreateDtoand returnFilesResponseDto.
Reviewed Changes
Copilot reviewed 92 out of 92 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/com/historialplus/historialplus/common/enums/... | Updated package for all enums and fixed imports. |
| src/main/java/com/historialplus/historialplus/util/TimeUtils.java | Added TimeUtils for centralized timezone logic. |
| src/main/java/com/historialplus/historialplus/internal/file/service/FileServiceImpl.java | Changed save to accept FilesCreateDto and map entity → DTO. |
| src/main/java/com/historialplus/historialplus/internal/file/controller/FileController.java | Updated controller to delegate record-detail lookup to service. |
| src/main/java/com/historialplus/historialplus/auth/filter/JwtAuthenticationFilter.java | Replaced manual ZonedDateTime with TimeUtils.getCurrentTime(). |
| src/main/java/com/historialplus/historialplus/audit/context/RequestContextExtractorImpl.java | Switched to TimeUtils.getCurrentInstant() for timestamp. |
Comments suppressed due to low confidence (1)
src/main/java/com/historialplus/historialplus/util/TimeUtils.java:13
- ZonedDateTime is not imported in this class, causing a compilation error. Please add
import java.time.ZonedDateTime;at the top.
return ZonedDateTime.now(ZoneId.of(TimeZoneConstants.LIMA)).toLocalDateTime();
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.