Fix on openExistingContact in Android and in example #108
Conversation
Sync staging 0.4.5 with master
|
@engylemure @lidongze91 is there a code conflict in previous PR's between the two of you? Please confirm you have tested and are certain this PR should be merged. |
| break; | ||
| } case "openExistingContact" :{ | ||
| final Contact contact = Contact.fromMap((HashMap)call.arguments); | ||
| final Contact contact = Contact.fromMap(((HashMap)call.argument("contact"))); |
There was a problem hiding this comment.
@engylemure why is this encapsulated in double parentheses?
There was a problem hiding this comment.
@lukasgit it is not needed sorry for that.
|
@lukasgit I'm sorry for the bug that was occurring in the Android, when i first developed these features (In the older flutter version) i had tested it in another project and was working just fine in a app that i was developing and the example. When i made the migration to the new version of flutter i had tested only in the example and no error or exceptions were occurring, so i considered that was working just fine, but it seems that was not the case. I had tested in my application and in the example seems that everything is working with these changes. |
3 participants
@lukasgit Hi Lukas, it seems that someone in another PR made some changes in how the internal arguments on the openExistingContacts work, but forgot too change it in Android.