Skip to content

Config updates #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukbrew25 merged 4 commits into from
Oct 4, 2025
Merged

Config updates #13

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e455f3b
Add example text in new device config fields
lukbrew25 Oct 4, 2025
596ca72
Use os.path.join() more commonly instead of direct path strings
lukbrew25 Oct 4, 2025
4fc1f38
Fix re-occuring syntax error
lukbrew25 Oct 4, 2025
1e0f916
Additional re-occuring syntax error fix
lukbrew25 Oct 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions openadbshell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
from threading import Thread, Event


adb_path = "adb\\adb.exe"
adb_path = os.path.join("adb", "adb.exe")


def save_config():
Expand Down Expand Up @@ -161,7 +161,7 @@ def save_and_close():
if not os.path.exists(adb_path):
messagebox.showerror("Error", "Selected ADB executable not "
"found. Resetting to default.")
adb_path_var.set("adb\\adb.exe")
adb_path_var.set(os.path.join("adb", "adb.exe"))
save_config()

# Save devices from the table
Expand Down Expand Up @@ -198,7 +198,7 @@ def clear_all_devices():

def add_device():
"""Add a new empty row to the device table."""
device_tree.insert('', 'end', values=('', '', 'N'))
device_tree.insert('', 'end', values=('EXAMPLE_NAME', 'IP:PORT', 'N'))

def delete_selected_device():
"""Delete the selected device from the table."""
Expand Down Expand Up @@ -248,7 +248,7 @@ def browse_adb():

def reset_adb():
"""Reset the ADB path to the default relative path."""
adb_path_var.set("adb\\adb.exe")
adb_path_var.set(os.path.join("adb", "adb.exe"))

def set_to_path():
"""Set the ADB path to just 'adb' to use the system PATH."""
Expand Down Expand Up @@ -377,7 +377,7 @@ def reset_all():
do_cust_command = True
rich_presence = True
do_mods = False
adb_path = "adb\\adb.exe"
adb_path = os.path.join("adb", "adb.exe")
cust_command_var.set(do_cust_command)
rich_presence_var.set(rich_presence)
do_mods_var.set(do_mods)
Expand Down