fix: absolute position issues #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes two issues with absolute position: 1. Text disappears when text is split into lines only, and target element does not contain any nested elements. 2. Splitting text with absolute position slightly changes the visual appearance of the text. This was due to the fact that we used `offsetTop` and `offsetLeft`, which do not have sub-pixel precision. Now, we use `getBoundingClientRect` to determine the size and position of split text nodes. This has a slight negative impact on performance. But it prevents text from visibly shifting when it is split/un-split.
Changes: 1. Removed property `instance.originals.` We store the original html content of the target elements in the data store. This makes it possible to revert the elements even if they were split by a different instance. I don't think its necessary to also store them as an instance property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues with absolute position:
Text disappear when text is split into lines only, and target
element does not contain any nested elements.
Splitting text with absolute position slightly changes the visual
appearance of the text. This was due to the fact that we used
offsetTopandoffsetLeft, which do not have sub-pixel precision.Now, we use
getBoundingClientRectto determine the size andposition of split text nodes. This has a slight negative impact on
performance. But it prevents text from visibly shifting when it
is split/un-split.
Before
The characters shift around slightly when text is split/un-split
before-absolute-position.2.mov
After
No visible change when text is split/un-split
after-absolute-position.mov