Fix issue 47 #48
Merged
Fix issue 47 #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: if you call `instance.split` multiple times, the html content of the target element(s) is replaced with "undefined" This was due to fact that all stored data associated with the elements is removed in the `revert` method. So after reverting the elements, the could not be split again (this bug was introduced in #41). Fix: store the original html content of the elements at the beginning of the split method instead of the constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: calling the
splitmethod multiple times on an instance causes the html content to be replaced with "undefined" (see #47)Fix, store the original html content of the target elements at the beginning of the split method, instead of in the constructor.
#closes #47