Wrong result with nested sets

[observ33r]

import { dequal } from 'dequal';

const set1 = new Set([
    new Set([1, 2]),
    new Set([1, 2]),
]);

const set2 = new Set([
    new Set([1, 2]),
    new Set([1, 4]),
]);

console.log('dequal:', dequal(set1, set2)); //true

[vladsuper5555]

The problem seems to be that you have duplicates in your set, and thus the length comparison (that otherwise would have been enough) is not working in this case.

If you really want the comparison to cover this case you can add a check for everything in the second set to be in the first one too. Example for changing the file:

This

if (ctor === Set) {
	if (foo.size !== bar.size) {
		return false;
	}
	for (len of foo) {
		tmp = len;
		if (tmp && typeof tmp === 'object') {
			tmp = find(bar, tmp);
			if (!tmp) return false;
		}
		if (!bar.has(tmp)) return false;
	}
	return true;
}

becomes this

if (ctor === Set) {
	if (foo.size !== bar.size) {
		return false;
	}
	for (len of foo) {
		tmp = len;
		if (tmp && typeof tmp === 'object') {
			tmp = find(bar, tmp);
			if (!tmp) return false;
		}
		if (!bar.has(tmp)) return false;
	}
	for (len of bar) {
		tmp = len;
		if (tmp && typeof tmp === 'object') {
			tmp = find(foo, tmp);
			if (!tmp) return false;
		}
		if (!foo.has(tmp)) return false;
	}
	return true;
}

Probably a bad fix that slows down stuff a lot, but should work if you really need it.