Misleading error when trying to load models with underscore#64
Merged
lukemelas merged 1 commit intolukemelas:masterfrom Aug 29, 2019
Merged
Misleading error when trying to load models with underscore#64lukemelas merged 1 commit intolukemelas:masterfrom
lukemelas merged 1 commit intolukemelas:masterfrom
Conversation
Thanks for this repo! Quick remark: I tried passing `efficientnet_b0` but you get `KeyError: 'efficientnet_b0'` if you try to pass this. Yet, if you pass a wrong model name such as `efficientnet_0` you get the following message. ``` ValueError: model_name should be one of: efficientnet_b0, efficientnet_b1, efficientnet_b2, efficientnet_b3, efficientnet_b4, efficientnet_b5, efficientnet_b6, efficientnet_b7 ``` The error should tell you to provide a name with a dash instead. ``` ValueError: model_name should be one of: efficientnet-b0, efficientnet-b1, efficientnet-b2, efficientnet-b3, efficientnet-b4, efficientnet-b5, efficientnet-b6, efficientnet-b7 ``` I think the proposed small change fixes the issue.
Owner
|
Yes, I totally agree, thanks for the PR! |
ulosc
pushed a commit
to ulosc/efficientnet
that referenced
this pull request
Aug 18, 2021
Improved error messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this repo @lukemelas .
Quick remark: I tried passing
efficientnet_b0but you getKeyError: 'efficientnet_b0'if you try to pass this.Yet, if you pass a wrong model name such as
efficientnet_0you get the following message.The error should tell you to provide a name with a dash instead.
I think the proposed small change fixes the issue.