fix include in calc.py#32
Conversation
|
Hey there, sorry for the late response! Thanks for pointing this out. I am currently looking into all the examples, updating them to newer bison (3.8) features. So your PR is much appreciated & the comments you mentioned are indeed wrong. The reason for the naming change was that previously Best |
|
Quick follow up question: Is the calc example running through without errors with this fix? |
|
No, unfortunately. Compilation errors are solved now, but the way the stdin is passed through the parser head-C-code through PyBison through Python seems to be broken currently. (Debugging is also a bit cumbersome as the build-files from the parser (parser and lexer files) cannot be found from within gdb during execution as of now. I will submit a PR that solves this.) |
|
If i recall correctly the example was working when i tried to run it. |
This change fixes compiler errors that are thrown when trying to run this example.
[...omitted warnings...] /tmp/pybison/pybison_Parser/tmp.l:8:10: fatal error: tokens.h: No such file or directory 8 | #include "tokens.h" | ^~~~~~~~~~ compilation terminated.The name of the header file has been changed in #20 but in some places there is still the old header name.
Also i wanted to ask about this code from the above mentioned #20

Aren't the comments wrong? Shouldn't the name be
tmp.tab.hThe code is here
Lastly, always in the doc folder, the walkthrough example seem to be outdated as well because it includes
tokens.h.Is there something i am missing and the file
tmp.tab.his renamed later totokens.hor was this just overlooked?