Skip to content

Conversation

@mastercodercat
Copy link
Contributor

@mastercodercat mastercodercat commented Jul 23, 2024

What does this PR introduce?

Custom upload function defined for cascade and sense providers and added activation ticket check function.
And also added example codes to use providers
Folder Upload feature added too

🚀 Feature

PR Checklist

  • Wrote Tests
  • Wrote & Generated Documentation (readme/natspec/dodoc)
  • Ran npm run lint && npm run lint:solidity (solhint)
  • Ran npm run format (prettier)
  • Ran npm run build
  • Ran npm run test

@mastercodercat
Copy link
Contributor Author

I added folder upload feature to cascade and sense providers.

Copy link
Contributor

@richtera richtera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want me to rebase this commit. There are a few problems with it.

  • it was pushed to an already merged branch.
  • the commits are not signed
  • the etc folders should not be checked in they are regenerated files and cannot be edited. (Actually I may not have noticed this on the original PR, but these files are ignored.)

I can remove those changes if you need me to, but I just ran across comments about the new upload folder method inside of the docs to cross check where it was in this repo.

@richtera
Copy link
Contributor

I understand now why you committed the etc files. Somehow it's not allowing the insertion of the new API into the docs. Checking it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants