fix(validator): header-length needs a value#36
Merged
Conversation
noirbee
approved these changes
Oct 8, 2025
noirbee
left a comment
There was a problem hiding this comment.
:tink: How did this never come up before ? Is the =100 from the infra repository ignored ?
Contributor
Author
I cannot really answer why 😖 |
Contributor
Author
|
@noirbee can you merge this for me pretty please? I can't because of the checks but not sure why the check is failing. |
Contributor
|
I think we use it in many public repositories... |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BUG FIX
Without specifying
:we tellgetoptthis option doesn't need a value, hence breaking the script:Example use-case from infra repo:
https://github.com/lumapps/infra/blob/master/.pre-commit-config.yaml#L107
NOTE
You might experience this only with recent version of getopt (especially if you're MacOS user and install the newer version)