This repository was archived by the owner on Nov 4, 2024. It is now read-only.
fix for mPDF export functionality#128
Open
bdolor wants to merge 1 commit intolumenlearning:masterfrom
BCcampus:master
Open
fix for mPDF export functionality#128bdolor wants to merge 1 commit intolumenlearning:masterfrom BCcampus:master
bdolor wants to merge 1 commit intolumenlearning:masterfrom
BCcampus:master
Conversation
Contributor
|
thanks brad, we'll check it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not knowing the workflow for how PB is updated within the candela stack, this PR risks interfering with that so feel free to disregard or make suggestions, though it resolves not being able to export mPDF (at least for me) and is consistent with where PB has gone: https://github.com/pressbooks/pressbooks/blob/dev/templates/admin/export.php#L15