Skip to content

feature: lazyload ws to work better with bundling for electron where ws is not used #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
levivilet merged 1 commit into from
May 5, 2025
Merged

feature: lazyload ws to work better with bundling for electron where ws is not used #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 21 additions & 12 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,30 @@
import { Buffer } from 'node:buffer'
import * as _ws from 'ws'

// workaround for jest or node bug
const WebSocketServer = _ws.WebSocketServer
? _ws.WebSocketServer
: // @ts-ignore
_ws.default.WebSocketServer
const createWebSocketServer = async () => {
const _ws = await import('ws')
// workaround for jest or node bug
const WebSocketServer = _ws.WebSocketServer
? _ws.WebSocketServer
: // @ts-ignore
_ws.default.WebSocketServer

const webSocketServer = new WebSocketServer({
noServer: true,
const webSocketServer = new WebSocketServer({
noServer: true,

// TODO not sure if ws compress is working at all
// perMessageDeflate: true
})
// TODO not sure if ws compress is working at all
// perMessageDeflate: true
})
return webSocketServer
}

export const handleUpgrade = (request, socket) => {
const doSocketUpgrade = (webSocketServer, request, socket) => {
const { promise, resolve } = Promise.withResolvers()
webSocketServer.handleUpgrade(request, socket, Buffer.alloc(0), resolve)
return promise
}

export const handleUpgrade = async (request, socket) => {
const webSocketServer = await createWebSocketServer()
const webSocket = await doSocketUpgrade(webSocketServer, request, socket)
return webSocket
}