forked from julianbro/lymixture
-
Notifications
You must be signed in to change notification settings - Fork 1
Naming of Likelihood Methods #3
Copy link
Copy link
Open
Labels
documentationImprovements or additions to documentationImprovements or additions to documentationenhancementNew feature or requestNew feature or requesthelp wantedExtra attention is neededExtra attention is needed
Metadata
Metadata
Assignees
Labels
documentationImprovements or additions to documentationImprovements or additions to documentationenhancementNew feature or requestNew feature or requesthelp wantedExtra attention is neededExtra attention is needed
In a mixture model, there are two different likelihoods in use:
In our model, we additionally want to compute the likelihoods of each patient under each mixture component, sometimes weighing them with the mixture coefficients and sometimes not.
So far, the result of these different likelihoods has been a mess of functions in the code. We currently have:
patient_component_likelihoods()patient_mixture_likelihoods()complete_data_likelihood()incomplete_data_likelihood()Each of them computable for slices/subsets of subgroups and components. But I think at least their names could be more informative. One could probably reduce this to two or three methods with appropriate names and a good choice of boolean flags (like
use_completeoruse_weighted).