Skip to content

Use Dir instead of Base in DirectoryRefresher #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rodaine merged 3 commits into from
Jan 10, 2019
Merged

Use Dir instead of Base in DirectoryRefresher #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d5679cd
Use Dir instead of Base
Jan 10, 2019
836e200
add write test
Jan 10, 2019
243e2ae
fix imports
Jan 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions loader/directory_refresher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ func (d *DirectoryRefresher) WatchDirectory(runtimePath string, appDirPath strin
}

func (d *DirectoryRefresher) ShouldRefresh(path string, op FileSystemOp) bool {
if filepath.Base(path) == d.currDir &&
op == Write || op == Create || op == Chmod {
if filepath.Dir(path) == d.currDir &&
(op == Write || op == Create || op == Chmod) {
return true
}
return false
Expand Down
13 changes: 13 additions & 0 deletions loader/loader_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,4 +158,17 @@ func TestDirectoryRefresher(t *testing.T) {

snapshot = loader.Snapshot()
assert.Equal("hello2", snapshot.Get("file2"))

// Write to the file
f, err := os.OpenFile(appDir+"/file2", os.O_RDWR, os.ModeAppend)
assert.NoError(err)
_, err = f.WriteString("hello3")
assert.NoError(err)
f.Sync()

// Wait for the update
<-runtime_update

snapshot = loader.Snapshot()
assert.Equal("hello3", snapshot.Get("file2"))
}