This repository was archived by the owner on Apr 20, 2026. It is now read-only.
containers should always be allowed to start when no sidecar is present#41
Merged
Merged
Conversation
…nt (#40) based on https://lyft.slack.com/archives/C017X524VC7/p1685639606706689?thread_ts=1685481685.730389&cid=C017X524VC7 when there are no sidecars we should allow all containers to start even when there is lack of container status. This fixes a regression introduced in #37 where we would block starting containers until we get container status reported. this triggers KillPod action in 1.16 as no progress can be made. --------- Co-authored-by: Tom Wanielista <tomwans@users.noreply.github.com>
tomwans
approved these changes
Jun 22, 2023
xinyuche
approved these changes
Jun 22, 2023
abhinavdahiya
changed the base branch from
release-1.16.15-lyft.4
to
release-1.16.15-lyft.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport (#40)
based on
https://lyft.slack.com/archives/C017X524VC7/p1685639606706689?thread_ts=1685481685.730389&cid=C017X524VC7
when there are no sidecars we should allow all containers to start even when there is lack of container status.
This fixes a regression introduced in
#37 where we would block starting containers until we get container status reported. this triggers KillPod action in 1.16 as no progress can be made.