[FIX] [18.0] Critical error at module install, failing unit test & misc warnings#20
Open
MattMarcha wants to merge 7 commits intolyra:developfrom
Open
[FIX] [18.0] Critical error at module install, failing unit test & misc warnings#20MattMarcha wants to merge 7 commits intolyra:developfrom
MattMarcha wants to merge 7 commits intolyra:developfrom
Conversation
…alling/loading module - Remove explicit translations exports when exported implicitly - Add reason for always invisible field in view - Add string attribute to field to avoid duplicate label on model
Replace request.env by self.env to fetch records & add 'sale' dependency
…om template This was causing some payment tests to fail
Allow upgrade scripts to actually trigger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-implementation of several fixes submitted on v4.1.0 PR that have been forgotten in the v4.2.0, causing regressions and test suite to fail again :
Also bring some fixes for new version :