A bunch of testcases for issues found + the fixes for these testcases#26
Open
ayourtch wants to merge 16 commits intom-schmoock:masterfrom
Open
A bunch of testcases for issues found + the fixes for these testcases#26ayourtch wants to merge 16 commits intom-schmoock:masterfrom
ayourtch wants to merge 16 commits intom-schmoock:masterfrom
Conversation
m-schmoock#22 - the testcase covers only less important half of this fix.
FIXME: This patch has a very noticeable performance impact on large inputs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Michael,
as we discussed - here is a bunch of commits, mostly sequenced in order "testcase then fix".
One of the fixes (multiline comment within the macro definition) causes the existing test to fail,
but this is primarily because it makes it test slightly different scenario, which is already failing today.
I don't know how to cleanly fix it, so instead I have first added a second testcase exposing the current problem and then commented out both testcases with a FIXME.
I also have a couple more branches: "experiment" with the original commits. The code in that branch can successfully process (minus the variadic macros) a ~50K line .h tree, including the standard includes and custom includes from VPP.
Another branch "new" is hopefully other candidates that might be interesting for you to include (I would definitely like to be able to have a search path, for example - and maybe the collection of corner-case tests could be also useful, though I don't know yet how to wrap it into proper tests).
Will be off for two weeks for vacation, so will be slower with replies / less capable in terms of corrections in the code. Anyway hopefully this is useful and matches what you'd expected.