Skip to content

fix: clean warning set in Release build #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kirill-jjj wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix: clean warning set in Release build #2

kirill-jjj wants to merge 7 commits into from

Conversation

@kirill-jjj
Copy link

@kirill-jjj kirill-jjj commented Jan 22, 2026 •
edited
Loading

Summary:

  • remove stray statement and unused exception variable
  • validate sample-rate parse result and avoid discarding nodiscard return
  • handle hotkey parse failures without throwing from wWinMain
  • update GUI submodule to include warning fixes (see fix: clean up GUI warnings GUI#1)

Testing:

  • msbuild FPRecorder.sln /m /p:Configuration=Release /p:Platform=x64 /p:PlatformToolset=v145

Notes:

  • Changes assisted by AI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kirill-jjj