Skip to content

fix: clean up GUI warnings #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m1maker merged 3 commits into from
Jan 24, 2026
Merged

fix: clean up GUI warnings #1

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06c3ae6
fix: cast control ids to HMENU safely
kirill-jjj Jan 22, 2026
d66fa59
fix: clamp timer and cast listbox results
kirill-jjj Jan 22, 2026
9e5e1f4
fix: avoid min/max macro clashes
kirill-jjj Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 23 additions & 11 deletions gui.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
#include <string>
#include <unordered_map>
#include <vector>
#include <limits>
#include <Windows.h>

namespace gui {
Expand Down Expand Up @@ -345,7 +346,18 @@ namespace gui {
}
else
{
return std::chrono::duration_cast<std::chrono::milliseconds>(std::chrono::steady_clock::now() - initTime).count();
const auto elapsed_ms = std::chrono::duration_cast<std::chrono::milliseconds>(
std::chrono::steady_clock::now() - initTime
).count();
if (elapsed_ms > (std::numeric_limits<int>::max)())
{
return (std::numeric_limits<int>::max)();
}
if (elapsed_ms < (std::numeric_limits<int>::min)())
{
return (std::numeric_limits<int>::min)();
}
return static_cast<int>(elapsed_ms);
}
}

Expand Down Expand Up @@ -418,7 +430,7 @@ namespace gui {
width,
height,
hwndParent,
(HMENU)id,
reinterpret_cast<HMENU>(static_cast<INT_PTR>(id)),
NULL,
NULL
);
Expand All @@ -435,7 +447,7 @@ namespace gui {
width,
height,
hwndParent,
(HMENU)id,
reinterpret_cast<HMENU>(static_cast<INT_PTR>(id)),
NULL,
NULL
);
Expand All @@ -452,7 +464,7 @@ namespace gui {
width,
height,
hwndParent,
(HMENU)id,
reinterpret_cast<HMENU>(static_cast<INT_PTR>(id)),
NULL,
NULL
);
Expand All @@ -476,7 +488,7 @@ namespace gui {
width,
height,
hwndParent,
(HMENU)id,
reinterpret_cast<HMENU>(static_cast<INT_PTR>(id)),
NULL,
NULL
);
Expand All @@ -496,7 +508,7 @@ namespace gui {
width,
height,
hwndParent,
(HMENU)id,
reinterpret_cast<HMENU>(static_cast<INT_PTR>(id)),
NULL,
NULL
);
Expand All @@ -514,7 +526,7 @@ namespace gui {

void delete_list_selections(HWND hwndList)
{
int count = SendMessage(hwndList, LB_GETSELCOUNT, 0, 0);
const int count = static_cast<int>(SendMessage(hwndList, LB_GETSELCOUNT, 0, 0));
if (count > 0)
{
std::vector<int> selections(count);
Expand Down Expand Up @@ -550,15 +562,15 @@ namespace gui {

int get_list_position(HWND hwndList)
{
return SendMessage(hwndList, LB_GETCURSEL, 0, 0);
return static_cast<int>(SendMessage(hwndList, LB_GETCURSEL, 0, 0));
}

std::wstring get_focused_list_item_name(HWND hwndList)
{
int focusedIndex = SendMessage(hwndList, LB_GETCURSEL, 0, 0);
const int focusedIndex = static_cast<int>(SendMessage(hwndList, LB_GETCURSEL, 0, 0));
if (focusedIndex != LB_ERR)
{
int textLength = SendMessage(hwndList, LB_GETTEXTLEN, focusedIndex, 0);
const int textLength = static_cast<int>(SendMessage(hwndList, LB_GETTEXTLEN, focusedIndex, 0));
if (textLength != LB_ERR)
{
std::wstring listItemText;
Expand Down Expand Up @@ -615,4 +627,4 @@ namespace gui {
{
SetWindowText(hwndEdit, lpszText);
}
}
}